deanmcpherson / react-native-sortable-listview

Drag drop capable wrapper of ListView for React Native
MIT License
917 stars 235 forks source link

mounting issue #157

Open markentingh opened 5 years ago

markentingh commented 5 years ago

When dragging a component, I noticed that the component being dragged executes the componentWillMount method upon drag start. I believe that this would be a bug. The component shouldn't have to remount just to be dragged.

In my case, I have a component that does some heavy processing upon being mounted, therefore, when I try to sort components, there is some huge lag between pressing and dragging the selected component.

madandrija commented 4 years ago

componentWillMount is now eligible for removal:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

Please update the following components: SortableListView