search

deanmcpherson / react-native-sortable-listview

Drag drop capable wrapper of ListView for React Native
MIT License
917 stars 236 forks source link

Android cannot be dragged and dropped #161

Open bwor opened 5 years ago

bwor commented 5 years ago

Running demo on android emulator, unable to drag and drop normally

fe-linjin commented 5 years ago

I also found this issue!

chetstone commented 5 years ago

I'm seeing this issue on the device after upgrading to react-native 0.59. I'll look into it. @nihgwu if I find a solution, can you please review?

nihgwu commented 5 years ago

@chetstone sure

chetstone commented 5 years ago

Trying Sortable with different RN versions, I find that the example works fine with 0.57.8. 0.58.6 has a serious problem --- when a row is picked up, it shifts the opening slot by one. In 0.59.3, it simply doesn't work. You can't pick up the row and drag.

Looking at the Changelog nothing obviously related jumps out for me except the the changes in Android SDK level.

kangju1 commented 5 years ago

has this been solved or any further progress?

chetstone commented 5 years ago

No I haven’t been able to find anything more. Any help would be appreciated.

On Sun, May 19, 2019 at 07:25 kangju1 notifications@github.com wrote:

has this been solved or any further progress?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deanmcpherson/react-native-sortable-listview/issues/161?email_source=notifications&email_token=AAHOLVYNIPSHGCVSZMYHDRDPWFILTA5CNFSM4GHXMYV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXCG4Q#issuecomment-493757298, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHOLV3NP4OGMIXRS7U6NTDPWFILTANCNFSM4GHXMYVQ .

chetstone commented 5 years ago

I've decided to change to react-native-sortable-list in my app. The code is much cleaner, it works better, especially when dragging to the end of the list, and it's compatible with RN 0.59. At least on Android. I haven't tried with iOS. One downside is that it doesn't seem to work well with very compact lists--- you need to have a bit of padding/margin between elements.

@nihgwu Since you're no longer working with react-native and I'm no longer working with this component, should we post an issue looking for a new maintainer? And also, I'm thinking of adding a note at the top of the README suggesting people not use this component for new projects. What do you think?