deanmcpherson / react-native-sortable-listview

Drag drop capable wrapper of ListView for React Native
MIT License
917 stars 235 forks source link

version 0.0.8 after dragging, scroll is not working anymore #22

Closed shaniceweiwei closed 8 years ago

deanmcpherson commented 8 years ago

Hi @shaniceweiwei, can you elaborate / provide an example?

shaniceweiwei commented 8 years ago

@deanmcpherson After dragging the cells (to reorder them), the whole thing can't scroll anymore.

invig commented 8 years ago

You need to set:

<SortableListView
      scrollEnabled={true}

The latest changes are treating it as false because of a bad condition.

For the maintainers:

341: scrollEnabled={!this.state.active && this.props.scrollEnabled}

This evaluates to false if this.props.scrollEnabled is undefined.

deanmcpherson commented 8 years ago

Thanks @invig, should have picked up on that.