search

deanoemcke / spaces

MIT License
66 stars 32 forks source link

Update chrome store version #13

Closed themightychris closed 5 years ago

themightychris commented 6 years ago

Could you push an update to the chrome store?

kirill-konshin commented 6 years ago

+1

deanoemcke commented 6 years ago

I will try to work on this soon. There's a couple of bugs I'd love to fix on this project.

ReActiveMicro commented 6 years ago

I'm going to hire someone on Freelancer to address some issues and make things more useable. I'll have the code branched here for review and approval. Assuming all is good then you can publish it.

It's a good extension and very useful. Just needs some bugs worked out. Get in touch with me anytime. Thx!

deanoemcke commented 6 years ago

@ReActiveMicro as mentioned in my email to you, it would be great if the code changes could be pushed here on gitHub as a new pull request. Thanks!

themightychris commented 6 years ago

Hi @ReActiveMicro , thanks for your work on Spaces!

From my own perspective only as another dedicated user, I don't want pinned tabs to be outside the save/restore of sessions. I have pinned tabs that are part of each saved space and it is important to me that pinned tabs stay inside the spaces flow. This behavior difference is the primary thing keeping me from using Workona. My workflow is to keep a set of projects open in spaces on different desktops, rather than switching between spaces within one window. If you haven't seen Workona before, check it out -- it sounds like it might already be a better implementation of what you're looking for. If you want to bring this behavior to Spaces, please consider making it an option that can be turned on so that folks relying on the existing behavior like me don't have our workflow broken upon updating

themightychris commented 6 years ago

@ReActiveMicro do you still expect to be able to upload the source code for that build? I'd love to get to see a PR for the work and maybe poke around at it a bit myself

deanoemcke commented 6 years ago

@ReActiveMicro It's very important that all code changes get reviewed before they are incorporated into the extension. This is not just to make sure that the new code does not contain any bugs. Perhaps even more importantly, as @themightychris has demonstrated, we need to make sure that any new features and design changes are the best choice for the majority of users.

There are always niche features that a single user may wish to have implemented, but if the feature is not wanted by the majority of other users then I prefer NOT to implement it, as adding too many of these sorts of features tends to lead to an extension that is complicated to understand and use.

themightychris commented 6 years ago

@deanoemcke could we return to the original request in this issue? The current code on github already fixes a number of issues that the current Chrome store version has. I'm referring people to this extension constantly and it sucks having to qualify with how to load an unpacked extension from GitHub. Is there much tech debt in the build->ship process or shortcomings in how extension updates work that would make shipping multiple patch updates in relatively short succession best to avoid?

@ReActiveMicro please open a separate pull request with your new code once you are able to, I'd like to keep this issue focused on clearing the minimal number of hurdles to just getting the current latest codebase shipped to the Chrome extensions store. I'm really looking forward to helping review and polish the work you've contributed, but since it's a bigger update than just bug fixes that could accelerate this release we should split up and parallelize the threads.

Thovthe commented 5 years ago

Prod prod.

BlkPingu commented 5 years ago

Any news on this?

deanoemcke commented 5 years ago

@themightychris I've just pushed v0.23 to the webstore. I'm really sorry I haven't done this sooner.

@ReActiveMicro Any chance you could send me another link to the custom code you had produced? I could look at putting it into a PR if the original author does not want to. Thanks :)

themightychris commented 5 years ago

thanks @deanoemcke!

No worries, I got a pile of PRs languishing in my own repos, your time is much appreciated!

faultylee commented 5 years ago

Chromium decided to disable Spaces by default, ask to confirm the "Read and change your browsing history" permission. I was worried for a while as I saw the last code change here was 10 months ago. I thought someone high jacked your webstore account until I found this thread. Might be good to put a note in the webstore and maybe here on the readme.