deanpcmad / sidekiq-limit_fetch

A Sidekiq plugin to support advanced queue control (limiting, pausing, blocking, querying)
MIT License
948 stars 140 forks source link

Error starting Sidekiq Ruby 2.7 Sidekiq 6.5.x #131

Closed samuelvaneck closed 2 years ago

samuelvaneck commented 2 years ago

Starting Sidekiq on Ruby 2.7.5 and Sidekiq 6.5.x

The error that we got is

WARN: NameError: undefined local variable or method `options' for #<Sidekiq::Manager:0x00007fe76f7ca408>
WARN: /Users/user/.rbenv/versions/2.7.5/lib/ruby/gems/2.7.0/bundler/gems/sidekiq-limit_fetch-bf9cee3b81e4/lib/sidekiq/extensions/manager.rb:9:in `start'

After downgrading Sidekiq to 6.4.x the error is gone.

Could be a duplicate of https://github.com/deanpcmad/sidekiq-limit_fetch/issues/129 but this is a slightly different error.

deanpcmad commented 2 years ago

Yep looks like the same issue as Sidekiq 6.5 changed the way options are set. Will try and sort this tonight

deanpcmad commented 2 years ago

This should now be fixed thanks to @BobbyMcWho. v4.3.0 has been released.