search

deanproxy / eMail

Command line SMTP client
https://www.deanproxy.com/code
GNU General Public License v2.0
136 stars 46 forks source link

fix cwd #29

Closed jerith666 closed 8 years ago

jerith666 commented 8 years ago

This was necessary to get eMail to build under nix. See https://github.com/NixOS/nixpkgs/pull/12708.

deanproxy commented 8 years ago

Thanks for the PR. Would you mind just changing the configure.ac file directly and then submitting a PR for just that file? The configure script will be overridden next time I run autoconf so your changes to that file will. e wiped out. Seems like you just need to merge the cwd variable over...

jerith666 commented 8 years ago

Sure, here you go. I admit to knowing almost nothing about how autoconf works -- I just hacked around at it until it built. :)

jerith666 commented 8 years ago

With the newer 1a1d864, I get this error building in nixos:

make[1]: Entering directory '/tmp/nix-build-email-git-2016-01-31.drv-0/eMail-1a1d8648b06096128048e2d41cd76ecf77243ed9-src/src'
gcc -g -O2 -Wall -W -DUSE_GNU_STRFTIME -I -I/src -I/include -I../include -I/dlib/include -I../dlib/include -DEMAIL_VERSION='"3.2.3-git"'  -DEMAIL_DIR='"/nix/store/dfkjs8p5vkhvajx82bii72fr5kcbyfp5-email-git-2016-01-31/etc/email"' -DHAVE_CONFIG_H   -c -o email.o email.c
email.c:34:19: fatal error: email.h: No such file or directory
 #include "email.h"
                   ^
compilation terminated.

I don't think it likes the relative paths used with the -I options.

cjmayo commented 8 years ago

This commit broke compiling for me (similarly to above error).

@jerith666 what was the original error on nix?

Does #35 fix it?

jerith666 commented 8 years ago

@cjmayo Yes, it's fixed -- thanks! I've opened https://github.com/NixOS/nixpkgs/pull/17606 to adopt this fix in nixpkgs.

I don't have the original error on hand, but that seems irrelevant now.