search

deanrad / meteor-package-kitchen

Easy way to create templated Meteor packages.
http://package-kitchen.meteor.com
15 stars 3 forks source link

Explicit version numbers are recommended in api.use() #15

Open chmac opened 9 years ago

chmac commented 9 years ago

Great project, thanks for sharing.

There's a long discussion here meteor/meteor#4170

Bottom line, it's best to say api.use('foo:bar@1.0.0'); in package.js. Otherwise, if you load your packages with your app (or maybe if you didn't meteor add foo:bar), then you'll get different package versions when you run the app versus when you run the tests.

Not sure how you'd implement that in this app, I suppose the slickest would be to poll atmosphere live and grab the latest version number automatically. But that might be a lot of code...

chmac commented 9 years ago

Oh yeah, and I'd recommend replacing things like mike:mocha-package with mike:mocha-package@0.5.8, which is a headache to maintain, but unfortunately, there doesn't seem to be an alternative yet... :-(

deanrad commented 9 years ago

There's already an example of how I pull latest versions from NPM - feel free to copy that pattern and send a PR! Thanks for the tip.

deanrad commented 9 years ago

And thanks for the link to this thread: meteor/meteor#4170, that is good to know, and I hope they accept some PRs to clarify..