deanwillis / p2psip-base-master

Master copy of P2PSIP Base draft
0 stars 0 forks source link

Gen-ART 3 #142

Closed deanwillis closed 11 years ago

deanwillis commented 11 years ago

From: Mary Barnes

Description: The message names are used inconsistently. The IANA registry has the message codes all lower case. There are places in the examples and the body of the document where the req part is missing, there is no "", the first letters are Upper case, etc. The messages are also used in a general sense - e.g., "MUST perform an Attach", which should really be stated as "MUST send an attach_req message)

Notes: I believe that all the inconsistencies problems have been fixed, but there is one thing that you mention that may be confusing in the spec. There is 3 different variants of the name for each message:

Text should be added in section 6.3.3 to explain the difference between these 3 notations.

petithug commented 11 years ago

I would prefer that you close the issue when the patch is accepted in Cullen's repo. Now I have to maintain yet another list....

petithug commented 11 years ago

Nevermind, I'll use the spreadsheet to know what is really done, and what is not.

deanwillis commented 11 years ago

On Dec 26, 2012, at 10:34 AM, Marc Petit-Huguenin notifications@github.com wrote:

I would prefer that you close the issue when the patch is accepted in Cullen's repo.

Okay, we could do that. At this time, I've "closed" the ones that I've merged and that I expect Cullen to accept; should he reject any, I will re-open.

I've reviewed all the pull-requests I have on-hand, merged the ones that look right (and plan to review with Cullen shortly) and commented on the ones that I had questions about, without merging them.

Dean

petithug commented 11 years ago

No, that's OK, I'll use the spreadsheet for that. And anyway if I manage to correctly link future pull with issues, they should be closed automatically.