deanwillis / p2psip-base-master

Master copy of P2PSIP Base draft
0 stars 0 forks source link

Gen-ART 84 #203

Closed deanwillis closed 11 years ago

deanwillis commented 11 years ago

From: Mary Barnes

Description: However, I still contend that there is inconsistency and the whole concept of an Attach function/process/whatever is not well defined. There are times when "attached" appears to be used purely as a verb rather than referring to the functionality, but it is not always clear. For example, the last two sentences in section 3.4: "Instead, we use the Attach request to establish a connection. Attach uses ICE [RFC5245] to establish the connection. It is assumed that the reader is familiar with ICE." I will note that the only mention of "Attach" previously was in the definitions for Connection Table ("Attach handshakes") and Routing Table ("some peers will have Attached"). The word "Attach" is used with the _req or the word "request" in places like the following in section 3.4 (1st sentence): "There are two cases where Attach is not used." I have no idea really whether this means this Attach function/process is not needed or the message is not required to be sent.

Notes: Will try to fix the text.

petithug commented 11 years ago

I think that a previous patches already took care of that, but I will keep this one open, and revisit it after all the gen-art patches are applied.