death-save / combat-carousel

Combat Carousel Foundry VTT module
https://deathsave.dev
GNU General Public License v3.0
18 stars 21 forks source link

Overlay Properties do not work in DnD5e system #158

Closed arriagagary closed 1 year ago

arriagagary commented 1 year ago

For Overlay Properties, I can change the icon fine. But no matter what I try to set the value to, it never works. I've tried all sort of different combinations of strings (including or excluding "data.", etc.), targeting all of the different attributes, including ones that definitely work in macros and other modules, but the value is always blank for me.

I've made sure to disable all other modules during my testing, so it was not caused by any issues with other mods and this one together.

This is the case for both versions 0.3.0 and 0.3.1 I tested in 0.2.5 and it DOES work in that version!

CombatCarousel_OverlayProperty_NotShowing

eclarke12 commented 1 year ago

Hi @arriagagary, the property values changed with v10 of Foundry's new data model. You can ask on the system channel on the main foundry discord to discover what they are for various things, but for your example of AC the value would be system.attributes.ac.value