search

death-save / combat-carousel

Combat Carousel Foundry VTT module
https://deathsave.dev
GNU General Public License v3.0
18 stars 21 forks source link

0.2.0 Alpha - Trashcan button (Delete Encounter) skips confirmation dialogue #57

Closed megahead11 closed 3 years ago

megahead11 commented 3 years ago

Describe the bug Clicking on the trashcan button (Delete Encounter) will end any combat (started or not) without popping up the foundry standard confirmation dialogue. This can lead to accidentally ending encounters via mis-click. Standard turn tracker still behaves as expected.

To Reproduce Steps to reproduce the behavior:

  1. Enable combat carousel
  2. Add tokens to combat and begin combat.
  3. Click the "Trashcan" in the carousel. You will see the encounter will end, but there will be no confirmation to do so.

Desktop (please complete the following information):

Darshyne commented 3 years ago

Same for me