death-save / combat-carousel

Combat Carousel Foundry VTT module
https://deathsave.dev
GNU General Public License v3.0
18 stars 21 forks source link

HP handling doesn't work well with temphp & tempmax (5e) #86

Closed mech-tools closed 2 years ago

mech-tools commented 3 years ago

Describe the bug Combat carousel is displaying the wrong amount of HP for npcs

To Reproduce Steps to reproduce the behavior:

  1. Add an unliked npc to the combat tracker
  2. Add 10 temp hp
  3. Add 10 temp max hp
  4. Add 10 HP to the creature (to reflect the added 10 temp max hp)
  5. Set temp hp to 0
  6. Set temp max hp to 0
  7. Combat carousel is displaying 10 hp extra (temp hp I guess)
  8. It's like combat carousel is not refreshing when some values change

Expected behavior HP bar should display the right amount of HP

Screenshots image

Environment Info (please complete the following information):

eclarke12 commented 2 years ago

I've validated this issue however due to system-specific customisations the 5e system does to the token HP and bars I'm not sure I'll be able to implement this in the near future.

eclarke12 commented 2 years ago

Actually I might have solved this...