search

death-save / combat-carousel

Combat Carousel Foundry VTT module
https://deathsave.dev
GNU General Public License v3.0
18 stars 21 forks source link

Carousel won't display when invalid attribute is used for bar/s #98

Closed SCDragon64 closed 3 years ago

SCDragon64 commented 3 years ago

Carousel won't display. The following errors appear in the console:

foundry.js:2013 TypeError: An error occurred while rendering CombatCarousel 55: Cannot set property 'title' of null at CombatCarousel.prepareTurnData (combat-carousel.mjs:248) at combat-carousel.mjs:313 at Array.map () at CombatCarousel.getData (combat-carousel.mjs:313) at CombatCarousel._render (foundry.js:2049) at M.:gift:call_wrapped [as call_wrapped] (libWrapper-wrapper.js:466) at CombatCarousel.:gift:Application.prototype._render#lib-wrapper (listeners.js:75) at CombatCarousel.:gift:Application.prototype._render#0 (libWrapper-wrapper.js:161) at CombatCarousel._render (combat-carousel.mjs:48) at CombatCarousel.render (foundry.js:2011)

combat-carousel.mjs:248 Uncaught (in promise) TypeError: Cannot set property 'title' of null at CombatCarousel.prepareTurnData (combat-carousel.mjs:248) at hooks.mjs:143 at Function._call (eval at (listeners.js:56), :4:14) at Function.callAll (foundry.js:153) at ClientDatabaseBackend.callback (foundry.js:8777) at foundry.js:8747 at Array.map () at ClientDatabaseBackend._handleCreateEmbeddedDocuments (foundry.js:8747) at ClientDatabaseBackend._createEmbeddedDocuments (foundry.js:8640) at async Function.createDocuments (document.mjs:332)foundry.js:2013 TypeError: An error occurred while rendering CombatCarousel 55: Cannot set property 'title' of null at CombatCarousel.prepareTurnData (combat-carousel.mjs:248) at combat-carousel.mjs:313 at Array.map () at CombatCarousel.getData (combat-carousel.mjs:313) at CombatCarousel._render (foundry.js:2049) at M.:gift:call_wrapped [as call_wrapped] (libWrapper-wrapper.js:466) at CombatCarousel.:gift:Application.prototype._render#lib-wrapper (listeners.js:75) at CombatCarousel.:gift:Application.prototype._render#0 (libWrapper-wrapper.js:161) at CombatCarousel._render (combat-carousel.mjs:48) at CombatCarousel.render (foundry.js:2011)

eclarke12 commented 3 years ago

image

Need to ensure that if an attribute in the field is not resolved, don't try to render the bar/title

SCDragon64 commented 3 years ago

The suggested change makes no difference in my case. Any other suggestions?

Regards,

Shaun

On Tue, 31 Aug 2021 at 17:15, errational @.***> wrote:

[image: image] https://user-images.githubusercontent.com/42503461/131538780-8b80fe23-6bf0-4e2d-876f-4cc59b5ee5b7.png

Need to ensure that if an attribute in the field is not resolved, don't try to render the bar/title

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/death-save/combat-carousel/issues/98#issuecomment-909381289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVMORUNAMUHEAQ65P64MUJDT7T5ZTANCNFSM5C7TQQOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

eclarke12 commented 3 years ago

Fixed by #100