search

death-save / combat-utility-belt

Combat Utility Belt module for Foundry Virtual Tabletop
https://deathsave.dev
GNU General Public License v3.0
53 stars 58 forks source link

Minor QOL and Concentrator issue with saving throw spells #145

Closed eclarke12 closed 4 years ago

eclarke12 commented 4 years ago

youngfoxToday at 9:43 PM @tposney @errational [UTC-7] Looks like when both CUB and MQoL are enabled Concentration activates with spells when there is no saving throw, but not when saving throws are requested.

tposney commented 4 years ago

I am guessing that CUB looks at the chat card for the spell to decide if the spell requires concentration. When a spell is cast that requires a saving throw the normal chat card is not displayed by minor-qol - just the saving throw roll so there is nothing for cub to find. I'll see if I can include the data that CUB is looking for in the save chat card that minor-qol generates

tposney commented 4 years ago

I had a quick look and I can add the div that cub is looking for - data-item-id easily. So I will push that out in the next minor-qol release and there should be no change required to CUB. I've tested in on one case and it seems to work - therefore it will work with all possible cases :)

eclarke12 commented 4 years ago

Awesome! Yeah I try to use the native functionality from the system (eg. data-item-id) so that I can stay aligned with core.

On Tue, May 5, 2020 at 6:50 AM tposney notifications@github.com wrote:

I had a quick look and I can add the div that cub is looking for - data-item-id easily. So I will push that out in the next minor-qol release and there should be no change required to CUB. I've tested in on one case and it seems to work - therefore it will work with all possible cases :)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/death-save/combat-utility-belt/issues/145#issuecomment-624067396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEI2JM2TBODY7ASQXLEDVLRQAKSBANCNFSM4MYOKCUQ .

eclarke12 commented 4 years ago

fixed in minor QOL