search

death-save / combat-utility-belt

Combat Utility Belt module for Foundry Virtual Tabletop
https://deathsave.dev
GNU General Public License v3.0
53 stars 58 forks source link

Linked conditions in chat does not option condition description. #154

Closed shawndibble closed 4 years ago

shawndibble commented 4 years ago

When adding a condition to a token, the chat adds a linked condition, but clicking the link does nothing. This is because the id on the linked condition does not match any entries in the world. Even after importing the condition.

Uncaught (in promise) TypeError: Cannot read property 'id' of undefined
    at HTMLAnchorElement._onClickEntityLink (foundry.js:13360)
    at HTMLBodyElement.dispatch (jquery.min.js:2)
    at HTMLBodyElement.v.handle (jquery.min.js:2)

Foundry: 0.5.5 CUB: 1.0.3 Browser: Chrome (not tested in other browsers)

Video of issue: https://streamable.com/8mf8y3

eclarke12 commented 4 years ago

@shawndibble I think this was a bug in foundry 055. Can you please provide more info about the Condition (eg. name, reference source, reference name etc)

shawndibble commented 4 years ago

This would be every condition that is from CUB. As can be seen from the video I posted. I can import all the conditions, but the link generated when I apply a condition to the token will not work. Same with conditions I don't import. If this is an issue with 055, then I can wait until the next beta version drops to see if the issue is fixed.

eclarke12 commented 4 years ago

It shouldn't be necessary to import the Journal entries anymore in case that's not obvious in the UI, as you can now choose Journal (C) as the reference source and choose from Compendia

On Tue, May 12, 2020 at 12:03 PM Shawn Dibble notifications@github.com wrote:

This would be every condition that is from CUB. As can be seen from the video I posted. I can import all the conditions, but the link generated when I apply a condition to the token will not work. Same with conditions I don't import. If this is an issue with 055, then I can wait until the next beta version drops to see if the issue is fixed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/death-save/combat-utility-belt/issues/154#issuecomment-627533279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEI2JIUUZ262ZH74CNSH3TRRGMQBANCNFSM4M7BYMAQ .

shawndibble commented 4 years ago

Confirmed with 0.5.7 that this issue is no longer an problem. Closing.