death-save / combat-utility-belt

Combat Utility Belt module for Foundry Virtual Tabletop
https://deathsave.dev
GNU General Public License v3.0
53 stars 58 forks source link

Dynamic Effects and About Time Integration #223

Open justinthejaguar opened 4 years ago

justinthejaguar commented 4 years ago

Is your feature request related to a problem? Please describe. This feature request is not related to any problem. This is a request for an improvement.

Describe the solution you'd like Could you collaborate with Tim Posney on the About Time and Dynamic Effects modules. It would be interesting to see if they could work together to make broken concentration from CUB also end the spell and cancel the timer. I imagined this would be incredibly useful overall for other spells to have integration with all three of these modules.

Describe alternatives you've considered I could continue to live my life the way that I do, and enjoy the ease that the two of you have already created in my life.

Additional context I like to make the world better, but you guys already did so much, and I feel like you could do it better than I do. Thanks for all of your work. I created a similar request on About Time. About Time Request

Ezalmanis commented 4 years ago

@eclarke12 I can somewhat help with this. As i've already intended to do it at least for DE

eclarke12 commented 4 years ago

I wouldn't recommend working on anything related to effects right now as there is a large breaking change coming in the form of the Active Effects system in core.

On Thu, Jul 23, 2020 at 9:40 AM Ezalmanis notifications@github.com wrote:

@eclarke12 https://github.com/eclarke12 I can somewhat help with this. As i've already intended to do it at least for DE

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/death-save/combat-utility-belt/issues/223#issuecomment-663110545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEI2JM2XHRI7L3RMHQODTTR5BRXNANCNFSM4PC43UUA .

Ezalmanis commented 4 years ago

I wouldn't recommend working on anything related to effects right now as there is a large breaking change coming in the form of the Active Effects system in core. On Thu, Jul 23, 2020 at 9:40 AM Ezalmanis @.***> wrote: @eclarke12 https://github.com/eclarke12 I can somewhat help with this. As i've already intended to do it at least for DE — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#223 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEI2JM2XHRI7L3RMHQODTTR5BRXNANCNFSM4PC43UUA .

Ah! If that's the case, ty for letting me know. If anything, I suppose I'll fork your repo for now, as I really see the DE thing as a QOL for me. The needed adjustments were not that big.

I hope you don't mind me occasionally offering help, I've taken a keen interest on a couple of your modules.

Cheers!