death-save / combat-utility-belt

Combat Utility Belt module for Foundry Virtual Tabletop
https://deathsave.dev
GNU General Public License v3.0
53 stars 58 forks source link

Condition Lab not opening when Plutonium module is enabled #355

Closed dstein766 closed 4 years ago

dstein766 commented 4 years ago

Describe the bug When used with Plutonium 1.14.6, Condition Lab won't open.

To Reproduce Steps to reproduce the behavior:

  1. Enable ONLY Plutonium 1.14.6 and CUB 1.3.4
  2. Click on Condition Lab.

Expected behavior Condition Lab data entry form should open. It does not. Disabling Plutonium = form opens as expected.

Environment Info (please complete the following information):

Additional context Problem began immediately after installation of today's CUB 1.3.4 update.
FWIW: my Firefox test instance has ZERO browser extensions.
The console shows NO error messages. Upon clicking "Condition Lab" the console displays "Foundry VTT | Rendering ConditionLab" but no additional relevant messages., and definitely no error messages.

Am wondering if this is somehow related to this change, as per CHANGELOG?? "Fixed Condition Lab not opening in worlds where the game system was unknown to CUB"

eclarke12 commented 4 years ago

Sorry I don't support compatibility with tools that are designed to circumvent copyright. Please feel free to raise an issue on the Plutonium issue tracker

dstein766 commented 4 years ago

I was actually in the process of closing the issue because, post-reboot, while the problem persisted it was no longer happening specifically with the named module. - i.e. enable just those 2 modules wasn't enough to cause the problem again as it had pre-reboot.

Post-reboot and lots of turning things on/off it seems like the culprit is some interaction between CUB and MagicItems 2.0.3. Toggling that module on/off creates/fixes the problem. I don't currently make use of MagicItems so I've simply disabled it, so not a big issue for me, but fyi.

------ Original Message ------ From: "errational" notifications@github.com To: "death-save/combat-utility-belt" combat-utility-belt@noreply.github.com Cc: "dstein766" dstein@jumpyip.com; "Author" author@noreply.github.com Sent: 11/14/2020 4:43:09 PM Subject: Re: [death-save/combat-utility-belt] Condition Lab not opening when used alongside specific module (#355)

Closed #355 https://github.com/death-save/combat-utility-belt/issues/355.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/death-save/combat-utility-belt/issues/355#event-3996888516, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6JSZ4UJGVLZEZN3SAJ6NDSP4PZ3ANCNFSM4TV3NJUQ.