death-save / combat-utility-belt

Combat Utility Belt module for Foundry Virtual Tabletop
https://deathsave.dev
GNU General Public License v3.0
53 stars 58 forks source link

Actor changes from Active Effects do not emit update that Triggler can listen for #678

Open MrXofar opened 2 years ago

MrXofar commented 2 years ago

When adding an Effect that changes data.abilities.[abl].value; Triggler is not picking up the change to trigger a condition.

Steps: Set CON = 10 Create triggler abilities.con.value < 1 Create Condition Lab item for "Condition" to trigger when abilities.con.value < 1 Add Effect data.abilities.con.value to add -10 CON now equals 0 "Condition" not set on token.

Delete Effect. Set CON = 0 manually. "Condition" set on token.

image image image

Environment Info:

eclarke12 commented 2 years ago

@MrXofar can you confirm whether this was working prior to CUB v1.9?

MrXofar commented 2 years ago

I cannot, this was the first time I've used this module.

eclarke12 commented 2 years ago

What I've discovered/rediscovered is that Active Effect changes do not trigger an update to the Actor the data in the same way as updating the sheet. This means Triggler currently can't listen for those changes. I will explore some different options but for now you may have to manually manage this.

MrXofar commented 2 years ago

Thanks for the follow up :)

On Tue, Jun 21, 2022, 12:51 AM errational @.***> wrote:

What I've discovered/rediscovered is that Active Effect changes do not trigger an update to the Actor the data in the same way as updating the sheet. This means Triggler currently can't listen for those changes. I will explore some different options but for now you may have to manually manage this.

— Reply to this email directly, view it on GitHub https://github.com/death-save/combat-utility-belt/issues/678#issuecomment-1161264598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZB63TTSPNVZYU2DVAYE6LVQFC5VANCNFSM5WS5OJ4A . You are receiving this because you were mentioned.Message ID: @.***>