death-save / maestro

Audio-focused QOL module for Foundry Virtual Tabletop
GNU General Public License v3.0
18 stars 18 forks source link

Token/Actors with no Hype Track are playing all paused hype tracks in pf2e #160

Open galaara98 opened 2 years ago

galaara98 commented 2 years ago

Describe the bug When an NPC (Possibly a PC also) is in an encounter and the token has a hype track set to No Playlist, No Track [None, None] OR a Playlist, No Track [%Playlist%, None] when the Actor's turn comes up ALL paused tracks are un-paused.

To Reproduce Steps to reproduce the behavior:

  1. setup an encounter with several tokens...

    • optionally setup a scene with ambient sound
    • optionally use Maestro to setup encounters with a default playlist
    • have some of your tokens have "Hype Track" set with a playlist and track
    • have some of your tokens have "Hype Track" set with no track
  2. Start the encounter

    • Progress the encounter slowly to allow all the media to reach clients, remove any start-stop issues.
    • Progress the encounter to listen to the tracks...
    • tokens that have a playlist and track set add to the currently listening interface
    • and when an encounter participant has a track, Maestro correctly pauses the other tracks
  3. When a participant has no Hype Track set (either no playlist and no track or playlist, but track is set to None)

    • All tracks that were paused are unpaused, causing a mayhem of audio to play.
  4. When a different participant is that does have a Hype Track is moved to then everything returns to normal (Maestro pauses every track but the one this participant is assigned to)

Expected behavior if Combat is started and a participant has No Hype Track, i can see a few expected results.

  1. If there is an Encounter Track, that should be the Only track playing
  2. if there is No encounter Track but there is a Scene Ambience Track, I can see this being allowed to play (or not, not sure what is the best expectation here)
  3. if there No encounter Track and No Scene Ambience, then all tracks should be paused.

Screenshots If applicable, add screenshots to help explain your problem.

Foundry Setup (please complete the following information):

Additional context