Combat Tracks playlist not playing when combat begins

[jshank]

Describe the bug The combat playlist is not started when combat begins

To Reproduce Steps to reproduce the behavior:

1. Install and enable Maestro
2. In settings, Enable Combat Track and Create Combat Tracks Playlist
3. Add music to now created Combat Tracks playlist
4. Add tokens to combat
5. Begin combat

Expected behavior Music from Combat Tracks playlist plays

Screenshots If applicable, add screenshots to help explain your problem.

Foundry Setup (please complete the following information):

• OS: [e.g. iOS] Ubuntu 22.04 LTS with Docker running felddy/foundryvtt image
• Browser [e.g. chrome, safari] Chrome
• Foundry Version [e.g. 0.6.6] 10.285
• Maestro Version [eg. 0.7.0]) 0.9.0
• DnD5e Game System - Version 2.0.2

Additional context Confirmed that Hype tracks are working properly. I downgraded to 10.278 (listed compatible version) and disabled all other modules. I am running 5e but still no luck. No errors in the console. I did confirm the playlist plays correctly when I hit the play button.

[jshank]

I've been digging around the combat-track.js file and putting some console.log statements on there to see what's going on. It looks like we're not getting anything back from const flags = CombatTrack.getCombatFlags(combat);, thus this just returns

        if (!flags && !defaultPlaylist) {
            return;
        }

I threw a console.log(JSON.stringify(flags)); and the console shows the result as undefined.

I also checked the helper method and console.log(JSON.stringify(combat.flags[MAESTRO.MODULE_NAME])) also gets undefined

[BernhardPosselt]

Same issue here. Not compatible with v10 I suppose?

[eclarke12]

@jshank @BernhardPosselt can you confirm you selected a Combat Track playlist in the Combat Tracker settings? Click the "gear" icon in the Combat Tracker, then the Music Note button in the header. Please note: as per issue #182 I will investigate defaulting the Combat Track playlist to the module-created playlist in the next update.

[BernhardPosselt]

Oh, that's how you configure it? I thought having the default Combat Tracks playlist would be enough and I completely glanced over the Music Note Icon. Works when configured that way.

Can we move that setting into the module settings perhaps?

[eclarke12]

Oh, that's how you configure it? I thought having the default Combat Tracks playlist would be enough and I completely glanced over the Music Note Icon. Works when configured that way.

Can we move that setting into the module settings perhaps?

Will be addressed #182

[jshank]

It works. I completely missed gear - music icon setting in the combat tracker. Like @BernhardPosselt, I thought configuration in settings was enough. Seems like #182 will help.