death-save / pin-cushion

Adds additional functionality around Map Pins
GNU General Public License v3.0
7 stars 18 forks source link

Some new feature Backgroundless Pins, Journal Image by default, Journal Image Thumbnail #70

Closed p4535992 closed 3 years ago

p4535992 commented 3 years ago

Why this pull request?

I know for a fact that many people use the following three modules always together "pin-cushion", "foundryvtt-journal-thumbnail", "FVTT-Backgroundless-Pins" the last two have not been updated for almost 10 months and it made sense to me (also to avoid a module conflict) update and integrate these features.

I've checked the licenses and it should be fine.

The combination of these features is in great demand in investigative games where you want to put objects in the room

p4535992 commented 3 years ago

Hey @eclarke12 sorry to bother, I wanted to know if you intend to get back to the project and / or if you could put me as a contributor so I try to work on it a bit (I wanted to avoid creating a new module with the same features).

eclarke12 commented 3 years ago

@p4535992 this PR seems to include a number of great ideas and changes! Unfortunately it seems quite opinionated and doesn't stick to the "tone" or existing "style" of the module so I can't merge it at this time. I will try to reply with some more specific feedback in the next few days.

If you'd like to create a new PR with just the code changes you are proposing rather than the structural changes shown here I will be more likely to approve.

Thanks!

p4535992 commented 3 years ago

k i will do that ty for your time