search

death-save / pin-cushion

Adds additional functionality around Map Pins
GNU General Public License v3.0
7 stars 18 forks source link

Players can't see previews (but GM can) #83

Open alexamacbett opened 2 years ago

alexamacbett commented 2 years ago

I am using the module in two games. In both, as the GM I am able to see the journal note preview popups, but my players cannot see them at all regardless of the permission level set on the journal entry. There doesn't appear to be a control for this in the module settings but other issues here are written as if to imply this is a feature the module has.

p4535992 commented 2 years ago

@alexamacbett Excuse me just for clarity, if you are using my fork (specify the module version for security), open these issues on my fork (so we don't disturb Death Save).

alexamacbett commented 2 years ago

@p4535992 Sorry, who are you? I don't know anything about a fork, I'm using version 1.5.0 for Foundry 0.8.6. Should I be using the fork instead? The main project seems relatively recently updated.

p4535992 commented 2 years ago

The 1.5.0 it is the main one. It was just to understand which version you were using, since Death Save was very focused on CUB and Carousel , I have made a fork (or a branch if you prefer) of the project to make it compatible with 9 (if you are using 0.8.9 nevermind) . If you are in foundryvtt 9 then you should use my fork.

alexamacbett commented 2 years ago

Confirming players can see previews on @p4535992's fork but not on 1.5.0 (on either foundry v0.8.9 or 9). My personal problem is resolved but this remains an issue with the module so I will leave this here.

Shuggaloaf commented 2 years ago

@p4535992 Any update on when these 2 branches may get merged? I know it's been about 6 months now since you started you work on it.

Personally, since it's been almost a year since the main branch was last updated, I'd love to see you just take over the mod (even if only on a temporary basis). That would give DeathSave all the time to work on CUB that they need.