deathandmayhem / jolly-roger

Dead men tell no tales!
MIT License
18 stars 5 forks source link

Verify type of key/secret for Google logins #2128

Closed ebroder closed 4 months ago

ebroder commented 4 months ago

I don't believe this constitutes a security issue, because Google.retrieveCredential validates that key is a string before issuing any database queries, and the key is long and random. It may technically be possible (if you get your hand on a key) to swipe someone else's pending login by passing secret: {"$ne": null} or similar.

I think this is largely a case of "if you have root, it's easy to get root", but it seems like good practice to clean it up anyway.