search

deathandmayhem / jolly-roger

Dead men tell no tales!
MIT License
18 stars 5 forks source link

Internal server error on join with Google Account #2160

Open jpd236 opened 4 months ago

jpd236 commented 4 months ago

Someone joining our test hunt via an invitation code (and signing up as a new user with a Google Account) hit an error in ensureHuntFolderPermission here. Full stack:

Exception while invoking method 'Hunts.methods.acceptHuntInvitationCode' Error: Internal Error
    at Gaxios._request (/built_app/bundle/programs/server/npm/node_modules/googleapis-common/node_modules/gaxios/build/src/gaxios.js:141:23)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
 => awaited here:
    at Function.Promise.await (/built_app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)
    at imports/server/gdrive.ts:134:3
    at /built_app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40
 => awaited here:
    at Function.Promise.await (/built_app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)
    at imports/server/gdrive.ts:249:3
    at /built_app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40
 => awaited here:
    at Function.Promise.await (/built_app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)
    at imports/server/addUserToHunt.ts:163:7

Seems like it might have just been a transient error. The folder was shared with them when I checked shortly afterwards.

Ideally we'd have retries and/or something a bit more graceful here.