Open dependabot[bot] opened 1 week ago
dependabot[bot]
commented
1 week ago One of your CI runs failed on this pull request, so Dependabot won't merge it.
Dependabot will still automatically merge this pull request if you amend it and your tests pass.
ebroder
commented
1 week ago Error: imports/server/subscribers.ts(91,7): error TS2532: Object is possibly 'undefined'.
Error: imports/server/subscribers.ts(102,7): error TS2532: Object is possibly 'undefined'.
Error: imports/server/subscribers.ts(146,7): error TS2532: Object is possibly 'undefined'.
Error: imports/server/subscribers.ts(152,7): error TS2532: Object is possibly 'undefined'.It's unhappy with some code of the form
if (!Object.prototype.hasOwnProperty.call(counters[name], user)) {
counters[name]![user] = 0;
}
counters[name]![user] += 1;which, fair, not sure why that wasn't an issue before.
Error: node_modules/@types/node/globals.d.ts(126,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; any(signals: AbortSignal[]): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }'.No idea what this is about - we're not using AbortSignal anywhere so it must be purely an issue with the type declarations. (Possibly interacting with TS's built-in declarations?)
/home/runner/work/jolly-roger/jolly-roger/imports/lib/puzzle-sort-and-group.ts
Error: 213:29 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion
Error: 241:10 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertionThis is a side effect of a new TS 5.5 feature and is kind of exciting! TS is now able to tell that .filter((x) => x !== undefined) drops undefined from the union of types in the array.
Bumps typescript from 5.4.5 to 5.5.2.
Release notes
Sourced from typescript's releases.
Commits
ce2e60eUpdate LKGf3b21a2š¤ Pick PR #58931 (Defer creation of barebonesLibSourc...) into release-5.5 (#...7b1620bš¤ Pick PR #58811 (fix(58801): "Move to file" on globa...) into release-5.5 (#...5367ae1Bump version to 5.5.2 and LKG02132e5š¤ Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5 (#...45b1e3cš¤ Pick PR #58872 (Fix declaration emit crash) into release-5.5 (#58874)17933eeš¤ Pick PR #58810 (Fixed declaration emit issue relate...) into release-5.5 (#...552b07eš¤ Pick PR #58786 (Fixed declaration emit crash relate...) into release-5.5 (#...39c9eebPick #58857 to release-5.5 (#58858)2b0009cš¤ Pick PR #58846 (Ensure the updates with crashes rev...) into release-5.5 (#...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @ebroder.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show