deathau / cm-typewriter-scroll-obsidian

Typewriter Scroll Obsidian Plugin
164 stars 15 forks source link

Disable top padding for codemirror view #38

Open ftvkyo opened 1 year ago

ftvkyo commented 1 year ago

This addresses https://github.com/deathau/cm-typewriter-scroll-obsidian/issues/35

This is a very simple change.

I guess depending on the maintainer's preferences, whether padding is enabled or not can be determined based on the obsidian config instead. So the padding would be disabled if the file title is shown or enabled otherwise. Padding the title can be also implemented as an alternative.

gbraad commented 1 year ago

Could this be configurable?

ftvkyo commented 1 year ago

@gbraad Thank for pointing it out. This is a quick fix because of the new layout of the editor which can display the filename as the title of the document (so there's a huge and confusing gap between them). But I think this indeed should be configurable.

(or maybe the title should be shifted down instead of the padding being removed at all).

I could at least try to make it a plugin setting (rather than determining it based on the display settings of obsidian itself) if I find some time.