search

deathau / markdownload

A Firefox and Google Chrome extension to clip websites and download them into a readable markdown file.
Apache License 2.0
2.85k stars 225 forks source link

Relative urls handling #260

Open arkadym opened 1 year ago

arkadym commented 1 year ago

Hi, i found it cannot handle relative images urls properly, extension replaces such urls with below

## In this article

1.  [Create a keystore file](chrome-extension://pcmpcfapbekmbjjkdalcgopdkipoggdi/_generated_background_page.html#create-a-keystore-file)
2.  [Find your keystore's signature](chrome-extension://pcmpcfapbekmbjjkdalcgopdkipoggdi/_generated_background_page.html#find-your-keystores-signature)
3.  [Build and sign your app](chrome-extension://pcmpcfapbekmbjjkdalcgopdkipoggdi/_generated_background_page.html#build-and-sign-your-app)
4.  [Define build properties in your project file](chrome-extension://pcmpcfapbekmbjjkdalcgopdkipoggdi/_generated_background_page.html#define-build-properties-in-your-project-file)

I took that from the MSDN page - https://learn.microsoft.com/en-us/dotnet/maui/android/deployment/publish-cli?view=net-maui-7.0

It has been tested using latest extension installed from chorme store using Chrome, Brave, Vivaldi browsers - same behavior.

zaxbux commented 11 months ago

Also having this issue with this extension and MSDN. Prototype fix: 58293542e85a377ca5d9d2a5be87860a56bb04eb (only handles <img> elements though).

tullyhansen commented 9 months ago

I believe same issue for me on https://www.australianbookreview.com.au/about/author/4411-davidhansen - giving something like the following:

## David Hansen

![David Hansen](safari-web-extension://4006157F-E0EA-4DB2-9841-A857CF225EB9/media/k2/users/10711.jpg)

David Hansen was Associate Professor of Art History & Art Theory at the ANU, and spent twenty-five years as a public art gallery director and curator, in Warrnambool, Mt Gambier, Melbourne, and Hobart. His essay ‘[Seeing Truganini](safari-web-extension://4006157F-E0EA-4DB2-9841-A857CF225EB9/abr-online/archive/2010/136-may-2010-no-321/2373-2010-calibre-prize-winner-seeing-truganini)’ was co-winner of the 2010 Calibre Essay Prize and winner of the Alfred Deakin Prize for an Essay Advancing Public Debate in the 2010 Victorian Premier’s Literary Awards. His essay ‘[Death Dance](safari-web-extension://4006157F-E0EA-4DB2-9841-A857CF225EB9/abr-online/archive/2007/137-april-2007-no-290/2375-2007-calibre-prize-commended-death-dance)’, an account of the imagery of the early colonial Indigenous leader Bungaree, was commended in the inaugural Calibre Essay Prize in 2007. He published a history of Australia’s regional galleries in _HG:60_, the Hamilton Gallery’s 60th anniversary publication. He died in January 2024.
WetHat commented 7 months ago

For web pages which have a HTML root tag with a class attribute whose value matches the removal criteria of Readability.js

The problem is that Readability.ls removes the <html> root tag from the document and , as a consequence, uses the wrong urls. Also, Markdownload loses access to the page meta-data.

Pull request #307 fixes this issue.

Following sites mentioned in issue this issue work correctly with this fix:

Note: This does not fix issue #201!

Dboingue commented 1 week ago

I agree with last post. I get same behavior (windows 10, edge updated) (made a post in #201) here wherre it happens (not all sites, but this root one). https://help.libreoffice.org/latest/en-US/text/swriter/01/outlinecontent_visibility.html