search

deathau / markdownload

A Firefox and Google Chrome extension to clip websites and download them into a readable markdown file.
Apache License 2.0
2.91k stars 226 forks source link

Resolve Obsidian Filename Determination Issue in background.js #290

Closed nekton39 closed 3 months ago

nekton39 commented 9 months ago

Description

This pull request addresses the Obsidian integration issue related to filename determination in the background.js file. The problem was identified in the use of article.title, which did not adhere to the "Template for title/filename" setting. The fix involves replacing article.title with await formatTitle(article), ensuring proper alignment with user configuration preferences.

Changes Made

Issue Reference

Closes #289

quanru commented 6 months ago

LGTM

quanru commented 4 months ago

@deathau Is it convenient to merge?

quanru commented 2 months ago

3.4.0 still doesn't work. Did you forget to build it?