deathau / markdownload

A Firefox and Google Chrome extension to clip websites and download them into a readable markdown file.
Apache License 2.0
2.91k stars 226 forks source link

Prevent Readability.js from removing the <html> element if it has a class attribute with specific values #307

Closed WetHat closed 3 months ago

WetHat commented 8 months ago

For web pages which have a HTML root tag with a class attribute whose value matches the removal criteria of Readability.js

The problem is that Readability.ls removes the <html> root tag, as a consequence, uses the wrong urls. Also, Markdownload loses access to the page meta-data.

This pull request fixes issue #260 by removing the class attribute from the <html> root tag.

Following sites mentioned in issue #260 work correctly with this fix:

Note: This does not fix issue #201 !