deathau / sliding-panes-obsidian

Andy Matuschak Mode as a plugin
747 stars 29 forks source link

Sliding Panes 3.3.0 stops working after 15.8 Update #113

Open jayambede opened 2 years ago

jayambede commented 2 years ago

Hello!

Thanks for this Plugin, it makes writing and keeping track of changes and relations much easier! Must be a hell of a ride with this constantly evolving program.

Unfortunately, with the update to 15.8 something must have gone sideways, at least in my configuration. While working fine before, Sliding Panes practically stopped working, at least obsidian behaves as if it wasn't there. I tried different settings, themes, reinstall. Nothing worked.

If needed, I can provide some screenshots.

Finally I switched back to 3.2.4 and erased the data.json. That seems to have worked, for now. But maybe some of the changes up to 3.3.0 have created possible conflicts with the changes in 15.8. And not being able to update doesn't sound like the real thing.

Would be nice, if you could take a look into it.

Just notify me, if you need anything.

Thanks again, Jay

megclaypool commented 2 years ago

I'm having this problem too -- I'm both glad and sorry to see it's not just me. I can confirm that on a Mac, using the Default theme with no snippets loaded, Sliding Panes is no longer working :(

MyNotes98 commented 2 years ago

How to revert to previous version?

jayambede commented 2 years ago

Download the relevant previous version from the github page, extract the relevant files to the folder of the plugin and confirm the overriding. Restart Obsidian and you should find the older version under the community plugins list. DOn't forget to NOT update it to the latest version, until this is resolved.

Alternatively you could try first to just delete the data.json file in the folder of the plugin. There might be some data-entries that prevent the plugin to work properly in conjunction with the 15.8 version. Seems like this solves the problem too. But I can't guarantee it does.

megclaypool commented 2 years ago

Deleting the data.json file did solve my problem 🎉 🎉 🎉 It looks like the data switched from

{
...
  "leafWidth": 500,
...
}

to

{
...
  "leafDesktopWidth": 700,
  "leafMobileWidth": 350,
...
}

I guess having the wrong key in there and the correct keys missing was really messing things up 🤷🏽‍♀️

jayambede commented 2 years ago

Well, could be that there was a mix-up of the entries in the different versions, though I do not know how this might happen when the version of the parent-app changes ... 🤷🏻‍♂

But, neverless: problem solved ... if it works 😎

venatiodecorus commented 2 years ago

I tried deleting data.json but the problem still appeared with the current version when opening more than 2 panes.

Levalicious commented 2 years ago

On 0.15.9, I'm experiencing the same issue. Version 3.3.0 doesn't work; considering I didn't update from a previous version, I didn't have any data.json values that looked out of place, and even then, deleting it had no effect on the problem.

I ended up rolling back to 3.2.5, so it seems like the problem is between there and 3.3.0, and (hopefully) 3.2.4 -> 3.2.5 should be fine (assuming we're experiencing the same errors.)

@jayambede , when you start up obsidian (with 3.3.0) does it ever give you a popup about this plugin failing to load? I can't remember if I was seeing that on mobile, desktop, or both, but it was happening somewhere. I'll try to check on that.

jayambede commented 2 years ago

@Levalicious - sorry for the late reply!: Actually I can't remember exactly, but I'm quite sure it didn't. Right now, after moving back to 3.2.4. and erasing the data.json file, everithing works fine even when I updated again to 3.3.0. Seems to me like it was a combination on change in versions and the config-entries.