deathbeds / importnb

notebook files as source
https://importnb.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
68 stars 5 forks source link

drop 3.7 add 3.12 #142

Closed tonyfast closed 1 year ago

tonyfast commented 1 year ago

dropping 3.7 cause it is eol and adding the fresh 3.12.

tonyfast commented 1 year ago

i showed up to work on this then bam... shits :green_circle: . thanks for sorting all that out.

should i merge this? are there any things that needed to be followed up on?

bollwyvl commented 1 year ago

In the hatch tooling refactor, I'm seeing we lost the test coverage under ipython -m... if you know an easy way to get that back, that'd be cool.

Ideally, we'd drop pytest-cov and run under coverage run -m pytest, with parallel = true, then coverage combine and coverage report them at the end to get a fully accurate picture, and establish a --fail-under.

Probably out of scope for this PR: we should look at upgrading (and using in CI) the linting mechanisms to include ruff and mypy... even if it's not possible to get passthrough types yet from imported notebooks, gotta start somewhere. We could also apply pyproject-fmt to pyproject.toml, though it has... a lot of opinions.

tonyfast commented 1 year ago

:sunglasses: i'll open some issues for these things.

with the typing, are you thinking notebook could be a source for types?

bollwyvl commented 1 year ago

thinking notebook could be a source for types?

If it can be (was?) done for JSON Schema, I don't see why we couldn't get it for notebooks.