deathbeds / ipydrawio

A standalone embedding of the FOSS drawio / mxgraph package into jupyterlab
https://ipydrawio.rtfd.io
Apache License 2.0
51 stars 4 forks source link

Enable data URIs for libraries #81

Closed bollwyvl closed 2 years ago

bollwyvl commented 2 years ago

Binder

References

Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (893e896) into master (ea4f7b8) will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   97.11%   97.39%   +0.27%     
==========================================
  Files          21       21              
  Lines         729      729              
  Branches       91       91              
==========================================
+ Hits          708      710       +2     
  Misses         12       12              
+ Partials        9        7       -2     
Impacted Files Coverage Δ
...s/ipydrawio-export/src/ipydrawio_export/manager.py 92.20% <0.00%> (+0.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea4f7b8...893e896. Read the comment docs.

bollwyvl commented 2 years ago

@nlooije please have a gander at the current state of things on binder/readthedocs: ended up going down rather a few rabbit holes to make some of the changes possible, and still have a few more things to do, but am thinking this is pretty close to releaseable.

nlooije commented 2 years ago

@bollwyvl it looks to be working great You seem to have tackled issues #80, #82 and #85 Thanks for the effort!