deathbeds / jupyterlab-deck

Lightweight presentations for JupyterLab
https://jupyterlab-deck.rtfd.io
BSD 3-Clause "New" or "Revised" License
41 stars 9 forks source link

Improve anchor navigation #30

Closed bollwyvl closed 2 years ago

bollwyvl commented 2 years ago

References

Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (90501f9) into main (7ce1cf6) will increase coverage by 2.17%. The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   90.60%   92.77%   +2.17%     
==========================================
  Files          13       13              
  Lines        1139     1177      +38     
  Branches      229      232       +3     
==========================================
+ Hits         1032     1092      +60     
+ Misses         66       45      -21     
+ Partials       41       40       -1     
Flag Coverage Δ
back-end 100.00% <ø> (ø)
front-end 92.66% <98.00%> (+2.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/jupyterlab-deck/src/plugin.ts 100.00% <ø> (ø)
js/jupyterlab-deck/src/notebook/presenter.ts 90.97% <96.29%> (+1.97%) :arrow_up:
js/jupyterlab-deck/src/manager.ts 88.49% <100.00%> (+2.89%) :arrow_up:
js/jupyterlab-deck/src/notebook/extension.ts 100.00% <100.00%> (ø)
js/jupyterlab-deck/src/tokens.ts 100.00% <100.00%> (ø)
js/jupyterlab-deck/src/tools/design.tsx 97.56% <100.00%> (+4.01%) :arrow_up:
js/jupyterlab-deck/src/tools/remote.tsx 95.45% <100.00%> (+12.59%) :arrow_up:
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bollwyvl commented 2 years ago

It looks like some more work is needed to figure out the windows tests, which reliably seem to fail on some of the cell type changes, no matter the retries. Will issue up, and move on...