Open brichet opened 8 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
d24d22c
) 93.66% compared to head (059b6f1
) 93.45%.:exclamation: Current head 059b6f1 differs from pull request most recent head 38b3623. Consider uploading reports for the commit 38b3623 to get more accurate results
Files | Patch % | Lines |
---|---|---|
js/jupyterlab-deck/src/notebook/presenter.ts | 0.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yep, we'll want a fixture that concretely demonstrates this pattern.
This could either be through adding a new fixture notebook in examples
, or updating an existing one to have this specific pattern so it can be observed, and therefore covered, and stay fixed.
@bollwyvl I added a test on this specific pattern.
Thanks for the work here! I'll try it soon :-)
Fixes a a navigation problem with sub-slide.
A sub-slide (1) without fragment and (2) followed by another sub-slide is ignored in the navigation. This PR solve it by checking if a sub-slide is preceded by another sub-slide.
Checklist
doit lint
locallyReferences
Expressed in https://github.com/deathbeds/jupyterlab-deck/issues/49
Code changes
When creating the extent (navigation) for a sub-slide, check if there is a previous sub-slide.
User-facing changes
None except for the navigation.
Backwards-incompatible changes
None