deathbeds / jupyterlab-starters

Starter notebooks and directories in JupyterLab
https://jupyterstarters.readthedocs.io
BSD 3-Clause "New" or "Revised" License
36 stars 8 forks source link

Addition of category and rank as starter props #78

Closed imcovangent closed 2 years ago

imcovangent commented 2 years ago

References

Issue #75

Code changes

Added two properties to the schema:

User-facing changes

Change is backwards compatible, but if category is given, then multiple headers are created in the launcher.

If rank is given, then the starters are sorted accordingly within the category.

Backwards-incompatible changes

N/A

Chores

imcovangent commented 2 years ago

@bollwyvl This PR replaces https://github.com/deathbeds/jupyterlab-starters/pull/76

Do you have any pointers for adding tests? I'm not familiar with the .robot files that have been used.

All existing tests still run, but the new rank and category properties are now untested.

For the rest the PR is done.

imcovangent commented 2 years ago

FYI: I made a new PR since I messed up the branches. See: https://github.com/deathbeds/jupyterlab-starters/pull/76

That PR has processed the comments from that PR.

bollwyvl commented 2 years ago

This was manually merged into #86, and will be part of #87. Thanks!