search

deathbeds / jyve

Jupyer Kernels, right inside JupyterLab
https://deathbeds.github.io/jyve/lab/
BSD 3-Clause "New" or "Revised" License
60 stars 14 forks source link

iframes eat mouse events #14

Closed sccolbert closed 6 years ago

sccolbert commented 6 years ago

When Jyve opens a new activity tab with iframe content, that iframe eats mouse events. This is noticeable when attempting to resize the panel using a splitter, since the splitter never gets the mouse event when the mouse is over the iframe.

The solution for this is a CSS trick (which is automatically applied if you use the jlab iframe widget): https://github.com/jupyterlab/jupyterlab/blob/master/packages/apputils/style/iframe.css#L17-L35 https://github.com/jupyterlab/jupyterlab/blob/master/packages/apputils/src/iframe.ts#L13

bollwyvl commented 6 years ago

Looks to be sorted up on demo! Thanks @sccolbert!

sccolbert commented 6 years ago

Awesome!