deathcap / nodeachrome

run Node.js scripts in Google Chrome (experimental)
MIT License
2 stars 0 forks source link

This extension includes the key file 'nodeachrome/app/node_modules/public-encrypt/test/test_key.pem'. You probably don't want to do that. #28

Open deathcap opened 8 years ago

deathcap commented 8 years ago

Chrome warns about .pem files in the unpacked extension:

There were warnings when trying to install this extension:
This extension includes the key file '/Users/admin/games/voxeljs/nodeachrome/app/node_modules/public-encrypt/test/test_key.pem'. You probably don't want to do that.
This extension includes the key file '/Users/admin/games/voxeljs/nodeachrome/app/node_modules/public-encrypt/test/test_rsa_privkey.pem'. You probably don't want to do that.
This extension includes the key file '/Users/admin/games/voxeljs/nodeachrome/app/node_modules/public-encrypt/test/test_rsa_pubkey.pem'. You probably don't want to do that.
This extension includes the key file '/Users/admin/games/voxeljs/nodeachrome/app/node_modules/npm/node_modules/npm-registry-couchapp/node_modules/couchapp/node_modules/http-proxy/test/fixtures/agent2-key.pem'. You probably don't want to do that.

These files are from a module dependency, which isn't needed, and not even node_modules is needed in the extension itself due to browserify bundling it all into one file. Could fix this by building the Chrome extension into a separate build directory.

screen shot 2016-05-05 at 6 56 05 pm
allavoie commented 7 years ago

Same here

neso613 commented 3 years ago

same issue :(