search

deathcap / wsmc

WebSocket proxy to Minecraft
33 stars 10 forks source link

Update to use protocol stream in node-minecraft-protocol #26

Open deathcap opened 8 years ago

deathcap commented 8 years ago

Requires https://github.com/PrismarineJS/node-minecraft-protocol/pull/320

deathcap commented 8 years ago

There is now a stream option on the client, could and should use it possibly, but note WSMC still disables packet framing/splitting transforms (maybe can re-enable now that https://github.com/PrismarineJS/node-minecraft-protocol/pull/316 Send framed packets in one push(), is merged, and consider removing framing/splitting later as an optimization, but keeping it now for code cleanliness)

deathcap commented 8 years ago

https://github.com/PrismarineJS/node-minecraft-protocol/pull/320 has been merged, updated this PR to use the new stream option to createClient(), but needs more testing - from my initial tests, I'm not getting any chunks, requires more investigation. Switching from new Client to createClient() is a fairly large change.