search

deathmarine / DiabloDrops

Bukkit plugin that adjusts the mob dropping mechanics to include regularly dropped enchanted items that could be commonly found in Diablo.
http://dev.bukkit.org/bukkit-plugins/diablodrops/
GNU General Public License v3.0
17 stars 19 forks source link

#216 Bug Report and suggestions #38

Closed UltraFaceguy closed 11 years ago

UltraFaceguy commented 11 years ago

New lore enchantments: Spine and Launch didn't seem to work, but entomb worked wonderfully.

Old lore enchants: Attack and Leech were not working. Defense seemed to be fine, though with some of my other plugins, it may be hard to tell. All potions effects working (except Wither, which hasn't ever really worked.)

Set Bonuses: Users can just rename items and get set bonuses! Named via anvil items are in italics, perhaps you can check for italics when applying the bonus. Potion effects and Fire, working perfectly, but Defense as a set bonus lowers the attacker's damage output

Suggestions: Add something in the lore to show the users what the set bonus is when the item is spawned in. The way I have imagined it, this would be completely optional for the user, as to avoid clutter! Example: http://pastie.org/5482538 Check items to see if they're actual DiaboDrops items before applying set bonus

ToppleTheNun commented 11 years ago

New Lore Enhancements: Thanks for the report on those, we'll check and see what's going on. Old Lore Enhancements: Thank you for confirming that Attack and Leech weren't working. We'll keep working on refining our processes there.

Set Bonuses: We'll fix defense while we're fixing the above lore enhancement bugs. It would be nearly impossible to stop the renaming of items unless Bukkit adds a AnvilCraftEvent or something of the sort that we can hook into.

Suggestions: We can definitely implement something of that type (set lore).

UltraFaceguy commented 11 years ago

Can you check for the italics character at the start of items before applying the set bonus? I'm fairly sure all player named items are in italics. That my be the way out without using any API.

ToppleTheNun commented 11 years ago

One of the issues with that is that someone may choose to use Italics as the color for their tier.

UltraFaceguy commented 11 years ago

Hrm. True, through I really see no other (simple) way around it. Perhaps just add a comment in the config stating that if you select italics as a tier color, you can't benefit from set bonuses?

It isn't the best solution, but until a good API comes out I think its your best bet. Otherwise, a lot of people who have powerful sets like myself may have to disable them, letting people just MAKE these sets is just way too gamebreaking.

ToppleTheNun commented 11 years ago

That may be the best solution we have available.

UltraFaceguy commented 11 years ago

Found another bug with this build. You can get sockets and tomes via the /dd command, but not from drops. Tested by spawning in and dropping ~1000 mobs. Weapons and armor drop fine, but no sockets or tomes.

ToppleTheNun commented 11 years ago

Known bug that we will be working on fixing.

deathmarine commented 11 years ago

Spawned 500 mobs... three had books, 1 had a socket diamond, 1 had an emerald.

deathmarine commented 11 years ago

Pics slaughter slaughter1

UltraFaceguy commented 11 years ago

On #216? I'll go try again, 1000 seemed like a pretttty big test group.

ToppleTheNun commented 11 years ago

It's done by chances, you have to remember that. If item drop is 3 out of 100 and socket drop rate is 1 out of 100, that means that there's a 0.03% chance that a mob will spawn with a socket item.

UltraFaceguy commented 11 years ago

Yeah, I set sockets to a higher percentage for the test... I just set it even higher, and indeed, they do drop, and frequently. I guess I was just a victim of bad fortune before. They do indeed drop!