search

deathmarine / DiabloDrops

Bukkit plugin that adjusts the mob dropping mechanics to include regularly dropped enchanted items that could be commonly found in Diablo.
http://dev.bukkit.org/bukkit-plugins/diablodrops/
GNU General Public License v3.0
17 stars 19 forks source link

Code Freeze. #45

Closed deathmarine closed 11 years ago

deathmarine commented 11 years ago

Since it doesn't seem like we are going to be making headway with compatible issues until the next Beta. I've been told that Only Development builds will contain the version information. Whether this is going to happen or not we really should wait before continuing. We keep getting mixed information about how development builds and such are going to work or how the structure of bukkit will change. I've already had to retract all of the uploads to bukkitdev for everything else so now is the time to plan.

ToppleTheNun commented 11 years ago

In my opinion, it'd be best to consider a rewrite of how we handle some of the plugin. Some code has become unneccessary (the book API comes to mind). We should also standardize some of our code so that we don't change it every time something else happens.

Opinion point 2 can be solved easily with the library thing I've told you about. It wouldn't be difficult to pull all code that deals with CB and NMS into a standalone library that we can hook into instead of the constantly changing CB and NMS code. We can change the libraries code and have a stable code base in DD rather than a constantly changing way of handling NMS and CB.

Have I mentioned NMS and CB yet?

UltraFaceguy commented 11 years ago

Do does that mean I can spam this ticket with important ideas for consideration?

ToppleTheNun commented 11 years ago

Sure thing.

UltraFaceguy commented 11 years ago

http://www.youtube.com/watch?v=P3ALwKeSEYs

UltraFaceguy commented 11 years ago

Okay, so you already know about my idea to make EnhanceAmount determine the number of sockets, but what about adding in sections in offenselore and defenselore for the different colors? This way people could make it so certain color sockets are more or less desirable, or so you have at least some idea of what to expect from the socketed version of an item?

ToppleTheNun commented 11 years ago

If we were to do that, it would switch from a text file to a YAML file, but that's possible.

UltraFaceguy commented 11 years ago

I figured as much, that or making a file for reddefesnelore bluedefenselore greendefenselore redoffenselore...

That option just seems like too much work XD

ToppleTheNun commented 11 years ago

Well, work on DiabloDrops has stopped and work has begun on DiabloLibrary.

deathmarine commented 11 years ago

This freeze has been lifted.