Build 499 bug report! - Githubissues

deathmarine / DiabloDrops

Bukkit plugin that adjusts the mob dropping mechanics to include regularly dropped enchanted items that could be commonly found in Diablo.

http://dev.bukkit.org/bukkit-plugins/diablodrops/

GNU General Public License v3.0

17 stars 19 forks source link

Build 499 bug report! #69

Open UltraFaceguy opened 11 years ago

UltraFaceguy commented 11 years ago

I LOVE the new socketing system! But, there are a few issues.

When socketing an item, all slots of the same color are socketed rather than just one
Attack still isn't really working
Unidentified items spawn with sockets on occasion.

Suggestions

If you get the same bonus in two sockets, they don't stack, so on the cook event, try to combine like enchantments into the color that you're currently socketing with.
Now that multiple sockets are a thing, add an item called a slot extender or a socket extender, which will drop like socket items, only its purpose when put into the furnace will be to add an empty (Socket) to the item, each item could only be extended once (Maybe add a &e or some color code to the end of the item's name to detect for this)

ToppleTheNun commented 11 years ago

The thing with all sockets of a color being filled is a bug and will be fixed.

Enhancements should stack. There's nothing in the code to prevent them from stacking.

I like the idea of a socket extender, though. I'll run it by @deathmarine later and see what he thinks.

UltraFaceguy commented 11 years ago

If you have -1 Speed on an item and another slot with -1 Speed, it typically only applied -1 Speed, rather than -2 speed, because of the two enhancements. I'm thinking of detecting similar enchants, and merging them.

ToppleTheNun commented 11 years ago

Hmmm. That'd be an interesting idea.

ToppleTheNun commented 11 years ago

Have you had the opportunity to test build 500+?

UltraFaceguy commented 11 years ago

Just did, and while items with different color sockets seem to be working great, like color ones seem to act strange.

when filling the first slot, there is a chance that it will clear the item, all enchants and lore.
If the first slot fills, you can try for the next one, but this always clears the item, or just the socket you're trying to fill.

ToppleTheNun commented 11 years ago

I've noticed the clearing of the item. Not entirely sure what's causing that, it'll need to be looked at heavily.