search

deathmarine / Ultrabans

Bukkit Plugin
www.modcrafting.com
GNU General Public License v3.0
16 stars 13 forks source link

Update src/com/modcrafting/ultrabans/db/SQL.java #8

Closed Haarolean closed 11 years ago

Haarolean commented 12 years ago

What about latin1 and UTF-8?

deathmarine commented 12 years ago

ISO8859-1 is the same character set that the plugin has used since the beginning. UTF-8 is great for Japanese, Chinese, Hebrew and Russian. However Minecraft only acccept a limited number of characters and tends to crash if specific characters are used in chat i.e. if you where to check ban a player with a non accepting character via international server your client will crash. I'm not against UTF-8 however the need hasn't arrised to change considering the limited character set used by minecraft. See http://wiki.vg/Chat

Haarolean commented 12 years ago

I'm still using your plugin, and all cyrillic characters became "????" in db.

deathmarine commented 12 years ago

That's weird considering the way the plugin handles strings doesn't change the encoding from UTF-16 except when loading it to a database. If you ALTER the database to UTF-8 and it still won't take then maybe its an issue with minecraft handling the characters. I wouldn't mind changing to UTF-8 but if it weren't for fear that the string would crash a client with a different language. I dunno.

Haarolean commented 12 years ago

haha, pff! i changed table charset to utf-8, sure.and all rows in table too

deathmarine commented 11 years ago

We'll try it out.

Haarolean commented 11 years ago

erm, ALSO we need to send info to mysql with another charset

deathmarine commented 11 years ago

https://github.com/deathmarine/Ultrabans/commit/40923ef619ddf52a18c535df15ba01f0f0cbce1f

This may ruin everyone's current databasing.