deathowl / go-metrics-prometheus

Prometheus support for go-metrics
Apache License 2.0
90 stars 32 forks source link

Can we start tagging releases? #22

Open vilakshminar opened 1 year ago

vilakshminar commented 1 year ago

Can we start tagging the https://github.com/deathowl/go-metrics-prometheus go modules? It's always good to use semantic version tags: https://go.dev/blog/publishing-go-modules It's not ideal to use pseudo-versions as they are a special type of pre-release version.

Hellseher commented 2 weeks ago

Is the project completely abandoned?

The tests fail to pass with the latest prometheus-client-golang:

--- FAIL: TestPrometheusCounterGetUpdated (5.00s)
    prometheusmetrics_test.go:74: Go-metrics value and prometheus metrics value do not match
--- FAIL: TestPrometheusGaugeGetUpdated (5.00s)
    prometheusmetrics_test.go:95: Go-metrics value and prometheus metrics value do not match
--- FAIL: TestPrometheusHistogramGetUpdated (5.00s)
    prometheusmetrics_test.go:169: Go-metrics value and prometheus metrics value for max do not match:
        + name:"test_subsys_metric_histogram"  help:"metric"  type:HISTOGRAM  metric:{histogram:{sample_count:100  sample_sum:129  bucket:{cumulative_count:1  upper_bound:0.05}  bucket:{cumulative_count:1  upper_bound:0.1}  bucket:{cumulative_count:1  upper_bound:0.25}  bucket:{cumulative_count:1  upper_bound:0.5}  bucket:{cumulative_count:1  upper_bound:0.75}  bucket:{cumulative_count:1  upper_bound:0.9}  bucket:{cumulative_count:5  upper_bound:0.95}  bucket:{cumulative_count:9  upper_bound:0.99}}}
        - name:"test_subsys_metric_histogram" help:"metric" type:HISTOGRAM metric:<histogram:<sample_count:100 sample_sum:129 bucket:<cumulative_count:1 upper_bound:0.05 > bucket:<cumulative_count:1 upper_bound:0.1 > bucket:<cumulative_count:1 upper_bound:0.25 > bucket:<cumulative_count:1 upper_bound:0.5 > bucket:<cumulative_count:1 upper_bound:0.75 > bucket:<cumulative_count:1 upper_bound:0.9 > bucket:<cumulative_count:5 upper_bound:0.95 > bucket:<cumulative_count:9 upper_bound:0.99 > > >
FAIL
FAIL    github.com/deathowl/go-metrics-prometheus       27.010s
FAIL