search

deathraygames / civ-clicker

Fork of the open source game CivClicker, by David Holley and Scott A. Colcord
http://deathraygames.com/play-online/civ-clicker/
GNU General Public License v3.0
56 stars 43 forks source link

Choose a framework for unit-tests #48

Closed olleharstedt closed 2 years ago

olleharstedt commented 7 years ago

I've used QUnit before and was pretty happy with that, will try it in my fork.

https://qunitjs.com/

Anahkiasen commented 7 years ago

If you haven't taken a look at it I highly recommend Jest – one of the top test frameworks at the moment. In particular the snapshot feature is very useful.

olleharstedt commented 7 years ago

OK, will have a look.

olleharstedt commented 7 years ago

Here's a comparison page: https://stackshare.io/stackups/jest-vs-mocha-vs-qunit

olleharstedt commented 7 years ago

But if you use Jest at work, let's pick that one.

Lukenickerson commented 2 years ago

I added jest as a dev dependency. We'll need some tests, but I think those can wait until there's been more refactoring.

olleharstedt commented 2 years ago

Cool. So you accept pull requests? I did some work on a fork some years ago[1]. Maybe some of those changes can be moved over to the main repo, piece by piece? With some discussion.

[1] http://olleharstedt.github.io/civclicker/2017/10/28/civclicker2-progress-report.html