Enhancement for /modbus_tk/defines.py

[GoogleCodeExporter]

Added FC7 (READ_EXCEPTION_STATUS), FC8 (DIAGNOSTIC) and FC23 
(READ_WRITE_MULTIPLE_REGISTERS)

Original issue reported on code.google.com by petar.e...@gmail.com on 12 Oct 2011 at 11:33

Attachments:

• defines.py.patch

[GoogleCodeExporter]

Hello Petar,
Thanks for submitting this implementation for the missing function codes. I've 
included it to the current dev version.
I don't have time currently to unit-test it. If you a little more time taht 
would be perfect.
Are you interested in joining the project maintainers? Just mail if you are ok.
Best
luc

Original comment by luc.jean@gmail.com on 12 Oct 2011 at 12:18

• Changed state: Fixed
• Added labels: Type-Enhancement
• Removed labels: Type-Patch

[GoogleCodeExporter]

Issue 24 has been merged into this issue.

Original comment by luc.jean@gmail.com on 12 Oct 2011 at 12:19

[GoogleCodeExporter]

Hi Luc,
I also don't have time for thorough testing. I implemented those function codes 
for the needs of my own project and they just work. So I assume they should 
work more or less for other people too.
I'm not sure I have the competence to participate in the project and or now I 
prefer to submit bug reports or additions which arise in the course of my work. 
I'm glad you offered though!
Best regards
Petar

Original comment by petar.e...@gmail.com on 12 Oct 2011 at 1:02

[GoogleCodeExporter]

OK, I'll try to find a little time for unit-testing but if you have tested it 
on your project, it is ok.
Thanks for your contribution in any form you like :)
Best
luc

Original comment by luc.jean@gmail.com on 12 Oct 2011 at 1:46

• Changed state: Verified