search

deavial / react-native-dialogbox

Dialog boxes for React Native (forked from react-native-popup)
Other
48 stars 21 forks source link

Figure out how to deal with React Native 47 #59

Closed deavial closed 7 years ago

deavial commented 7 years ago

I need to update the project to React Native 0.47. However, that will break anyone using a version of React Native lower than 0.47. Yes, we have seen this before with 0.25.

React Native has removed PropTypes as opposed to deprecating them, as well as createClass. This is in-line with React 16. While we do not use createClass, we do use PropTypes.

We are supposed to import PropTypes from a new library called prop-types. Changing this code and adding the dependency will break all code running React Native 0.25 -> 0.46.

Another (poor) option is to remove (or comment out) all PropType checking until it can be reasonably assumed that the world has moved on from the older versions.

I am not sure which path to take and will be investigating how other vendors are handling this.

Comments are welcome.

deavial commented 7 years ago

used method from react-native-firebase