search

deb-sig / double-entry-generator

Rule-based double-entry bookkeeping importer (from Alipay/WeChat/Huobi etc. to Beancount/Ledger).
https://github.com/deb-sig/double-entry-generator
Apache License 2.0
537 stars 79 forks source link

fix two issues #55

Closed shuxiao9058 closed 2 years ago

shuxiao9058 commented 2 years ago
shuxiao9058 commented 2 years ago

And make posting after meta info.

Triple-Z commented 2 years ago

And make posting after meta info.

Why the posting should place after the metadata?

shuxiao9058 commented 2 years ago

Refered to the Python beancount parse module which put posting after metadata.

Triple-Z commented 2 years ago

SGTM, /cc @gaocegege

shuxiao9058 commented 2 years ago

I suggest that add an extra test for this "csv parse issue column 64: bare " in non-quoted-field"

done with recent commit. #4bf5683

Triple-Z commented 2 years ago

Maybe we can sync this fix to alipay provider too.

shuxiao9058 commented 2 years ago

Maybe we can sync this fix to alipay provider too.

done with commit https://github.com/deb-sig/double-entry-generator/pull/55/commits/c0d3a77f1dbd79cb0c35a2a6a9096b915cb74472

gaocegege commented 2 years ago

Thanks for your contribution! :tada: :+1: