refact: clarify the `type` and `txType` in whole codebase

deb-sig / double-entry-generator

Rule-based double-entry bookkeeping importer (from Alipay/WeChat/Huobi etc. to Beancount/Ledger).

https://github.com/deb-sig/double-entry-generator

Apache License 2.0

537 stars 79 forks source link

refact: clarify the `type` and `txType` in whole codebase #75

Closed Triple-Z closed 2 years ago

Triple-Z commented 2 years ago

Type stands for Buy/Sell or In/Out.
TxType is the specific paying definition which can be various for every provider.

BREAKING CHANGE: the config fields(type and txType) for huobi and htsec providers are redefined in this PR, so the user who used this tool before with those providers MUST modify the config for huobi or htsec provider after upgrading the tool.

resolves #60

Signed-off-by: Triple-Z me@triplez.cn

Triple-Z commented 2 years ago

I recommend releasing the 2.x version for the breaking changes.

/cc @gaocegege

Triple-Z commented 2 years ago

@gaocegege We can reply on CI though 🤣