search

deb0ch / emacs-winum

Window numbers for Emacs - Navigate windows and frames using numbers
143 stars 13 forks source link

Insert created frames into/remove deleted frames from winum--frames-table when scope is frame-local. #10

Closed Alexander-Miller closed 7 years ago

Alexander-Miller commented 7 years ago

There's no entry for a frame right after it's created, which makes spaceline throw a silent error. Entries for killed frames are also never cleaned up. This PR takes care of both issues.

Alexander-Miller commented 7 years ago

On second thought: hold up. I need to go hunt some edge cases.

Alexander-Miller commented 7 years ago

New version pushed, it should now correctly cover the case of created frames.

deb0ch commented 7 years ago

Merged ! 👍 ✨

Thank you very much for this, I indeed didn't catch that logic flaw. Don't hesitate to send other ones, I'll try to be quicker at merging them !

By the way, how did that silent spaceline error manifest itself ? Was it visible to the user in some way ?

Alexander-Miller commented 7 years ago

It's been so long that I've forgotten most of the details. I do know I was debugging some unrelated modeline issue in treemacs and randomly ran into this. The error isn't really user-visible, there's just an error in the messages buffer that looks like Error during redisplay: (eval (spaceline-ml-main)) signaled <some errror>.

deb0ch commented 7 years ago

Anyways, nice catch and thank you for the fix !