debabratapatra / angular-tree-grid

Angular 10 Tree Grid
https://curiouslinks.com/pages/angular-tree-grid/demo
MIT License
31 stars 17 forks source link

Cancel icon not work in edit mode #53

Closed Danted96 closed 2 years ago

Danted96 commented 2 years ago

Hi, I'm using the tree grid with angular version 8, unfortunately I don't understand why when I try to modify a row the cancel icon saves instead of canceling. What am I doing wrong?

debabratapatra commented 2 years ago

Can you please reproduce this issue on Stackblitz?

Danted96 commented 2 years ago

Do you know how I can downgrade angular version on stackblits?

Il giorno gio 16 dic 2021 alle ore 06:14 Debabrata Patra < @.***> ha scritto:

Can you please reproduce this issue on Stackblitz?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-995446329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2OE3MT2WD3V2XGDOF3URFYURANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Danted96 commented 2 years ago

Because I'm using 8 but there is 12

Il giorno gio 16 dic 2021 alle ore 09:40 DANTE DOMIZI < @.***> ha scritto:

Do you know how I can downgrade angular version on stackblits?

Il giorno gio 16 dic 2021 alle ore 06:14 Debabrata Patra < @.***> ha scritto:

Can you please reproduce this issue on Stackblitz?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-995446329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2OE3MT2WD3V2XGDOF3URFYURANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Danted96 commented 2 years ago

https://curiouslinks.com/pages/angular-fix-header-grid/demo/#/add_edit_delete

But the error is the same as you can see in the documentation of the angular fix header grid documentation, when you go to edit both the x and the floppy save the changes made, it gives me the same problem

Il giorno gio 16 dic 2021 alle ore 09:41 DANTE DOMIZI < @.***> ha scritto:

Because I'm using 8 but there is 12

Il giorno gio 16 dic 2021 alle ore 09:40 DANTE DOMIZI < @.***> ha scritto:

Do you know how I can downgrade angular version on stackblits?

Il giorno gio 16 dic 2021 alle ore 06:14 Debabrata Patra < @.***> ha scritto:

Can you please reproduce this issue on Stackblitz?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-995446329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2OE3MT2WD3V2XGDOF3URFYURANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

debabratapatra commented 2 years ago
image

I don't see any error. Please send a screenshot at least.

Danted96 commented 2 years ago

1) Click edit icon [image: 1.PNG] 2) Edit name Tiki in Guz [image: 2.PNG] 3) Click in the x button for undo, but the filed was saved [image: 3.PNG]

Il giorno gio 16 dic 2021 alle ore 12:09 Debabrata Patra < @.***> ha scritto:

[image: image] https://user-images.githubusercontent.com/5602062/146361031-5b59c2f2-084e-4b59-aebe-01a545e19568.png I don't see any error. Please send a screenshot at least.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-995691381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2K3R7ABEVHP6M2VGO3URHCIBANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

debabratapatra commented 2 years ago

Please use version 2.8.71. And let me know this fixes the issue.

Danted96 commented 2 years ago

Still not working with version 2.8.71, and the version 1.1.0 dosen't exist

Il ven 17 dic 2021, 18:34 Debabrata Patra @.***> ha scritto:

Please use version 1.1.0. And let me know this fixes the issue.

— Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-996898683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2PZ3TE7VU3AOOYG633URNYATANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

--

debabratapatra commented 2 years ago

https://curiouslinks.com/pages/angular-tree-grid/demo/#/add_edit_delete

This example uses version 2.8.71. And it is working for me. If it is still not working for you. You can send me a zip of the minimal files that reproduces this issue. I will look into it.

Danted96 commented 2 years ago

I discovered one thing, if I add the property edit_parent: true my problem disappears, the problem is that I don't want the parent to be editable

Il giorno lun 20 dic 2021 alle ore 11:09 Debabrata Patra < @.***> ha scritto:

https://curiouslinks.com/pages/angular-tree-grid/demo/#/add_edit_delete

This example uses version 2.8.71. And it is working for me. If it is still not working for you. You can send me a zip of the minimal files that reproduces this issue. I will look into it.

— Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-997780144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2OV2ZE2EAFPVWLEEM3UR36EJANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

--

debabratapatra commented 2 years ago

I can now reproduce this issue. I think I fixed it in 2.8.76. Please use this version and let me know if this fixes the issue. Thanks.

Danted96 commented 2 years ago

Now It works!!! Thank you very very much!!!

Il giorno lun 20 dic 2021 alle ore 16:37 Debabrata Patra < @.***> ha scritto:

I can now reproduce this issue. I think I fixed it in 2.8.76. Please use this version and let me know if this fixes the issue. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/debabratapatra/angular-tree-grid/issues/53#issuecomment-998034543, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPQC2IY6Y5T2JWPZQICKNTUR5ESXANCNFSM5J6FYX4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

--